]> dgit.raspbian.org Git - gnome-shell.git/commit
appFavorites: Only emit :changed signal on changes
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 16 Apr 2026 02:33:45 +0000 (04:33 +0200)
committerMarge Bot <marge-bot@gnome.org>
Fri, 17 Apr 2026 14:40:53 +0000 (14:40 +0000)
commitc5aea946fd48b2176b7e65bf92a3c0ff951678cd
tree42a97db1b7dc0a8fb983daa3a9c78caccdbc2613
parent3df8e4dd0e14ecc4221ef5f05eebeac1c9949a3d
appFavorites: Only emit :changed signal on changes

We were emitting the :changed signal on every setting or app-filter
change even though the actual favorites list might not have changed.

So now every time it's relevant, check if something is changed before
emitting the :changed signal.

We do a deep check of the app IDs as potentially an app could have
been removed while another is being installed during the same update
window, and the length of the IDs list wouldn't change.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4180>
js/ui/appFavorites.js